check return type of this type predicates by Zzzen · Pull Request #57341 · microsoft/TypeScript

Zzzen · 2024-02-08T15:17:41Z

jakebailey · 2024-02-08T18:49:19Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this faster
@typescript-bot pack this

typescript-bot · 2024-02-08T18:49:21Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 89a7208. You can monitor the build here.

typescript-bot · 2024-02-08T18:49:21Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 89a7208. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-08T18:49:21Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 89a7208. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-08T18:49:21Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 89a7208. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-08T18:49:21Z

Heya @jakebailey, I've started to run the faster perf test suite on this PR at 89a7208. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-08T18:52:02Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159791/artifacts?artifactName=tgz&fileId=D4AC5010FA6A8D0B5A0E43EF24C131CCDFD8492F0B351F26911A8B24BD76977C02&fileName=/typescript-5.4.0-insiders.20240208.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-57341-6".;

typescript-bot · 2024-02-08T19:14:12Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57341/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-02-08T19:23:29Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,668k (± 0.01%)}	_{295,677k (± 0.01%)}	_~	_295,643k	_295,729k	_{p=0.810 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.67s (± 0.15%)}	_{+0.01s (+ 0.31%)}	_2.66s	_2.67s	_{p=0.033 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 0.99%)}	_~	_0.82s	_0.84s	_{p=0.859 n=6}
_{Check Time}	_{8.23s (± 0.33%)}	_{8.23s (± 0.14%)}	_~	_8.22s	_8.25s	_{p=0.870 n=6}
_{Emit Time}	_{7.08s (± 0.39%)}	_{7.10s (± 0.22%)}	_~	_7.09s	_7.13s	_{p=0.357 n=6}
_{Total Time}	_{18.79s (± 0.26%)}	_{18.82s (± 0.13%)}	_~	_18.80s	_18.87s	_{p=0.466 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,537k (± 1.25%)}	_{194,449k (± 1.62%)}	_~	_191,512k	_197,401k	_{p=0.378 n=6}
_{Parse Time}	_{1.36s (± 1.20%)}	_{1.36s (± 1.42%)}	_~	_1.34s	_1.39s	_{p=0.680 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.36s (± 0.40%)}	_{9.38s (± 0.28%)}	_~	_9.34s	_9.42s	_{p=0.518 n=6}
_{Emit Time}	_{2.62s (± 0.31%)}	_{2.61s (± 0.80%)}	_~	_2.57s	_2.63s	_{p=0.181 n=6}
_{Total Time}	_{14.07s (± 0.29%)}	_{14.07s (± 0.34%)}	_~	_13.98s	_14.12s	_{p=0.936 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,455k (± 0.00%)}	_{347,465k (± 0.01%)}	_~	_347,429k	_347,484k	_{p=0.297 n=6}
_{Parse Time}	_{2.47s (± 0.51%)}	_{2.47s (± 0.42%)}	_~	_2.46s	_2.49s	_{p=0.868 n=6}
_{Bind Time}	_{0.93s (± 0.59%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.95s (± 0.29%)}	_{6.92s (± 0.26%)}	_{-0.03s (- 0.43%)}	_6.90s	_6.94s	_{p=0.035 n=6}
_{Emit Time}	_{4.06s (± 0.39%)}	_{4.05s (± 0.31%)}	_~	_4.04s	_4.07s	_{p=0.323 n=6}
_{Total Time}	_{14.40s (± 0.17%)}	_{14.37s (± 0.19%)}	_{-0.04s (- 0.24%)}	_14.34s	_14.42s	_{p=0.035 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,852k (± 0.00%)}	_{302,847k (± 0.00%)}	_~	_302,836k	_302,858k	_{p=0.261 n=6}
_{Parse Time}	_{2.01s (± 0.51%)}	_{2.01s (± 0.58%)}	_~	_2.00s	_2.03s	_{p=0.801 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{1.00s (± 0.63%)}	_~	_0.99s	_1.01s	_{p=0.201 n=6}
_{Check Time}	_{6.36s (± 0.22%)}	_{6.35s (± 0.27%)}	_~	_6.33s	_6.38s	_{p=0.744 n=6}
_{Emit Time}	_{3.61s (± 0.37%)}	_{3.60s (± 0.57%)}	_~	_3.59s	_3.63s	_{p=0.448 n=6}
_{Total Time}	_{12.98s (± 0.22%)}	_{12.97s (± 0.22%)}	_~	_12.92s	_13.00s	_{p=0.871 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,353k (± 0.00%)}	_{511,377k (± 0.00%)}	_{+24k (+ 0.00%)}	_511,358k	_511,397k	_{p=0.044 n=6}
_{Parse Time}	_{2.66s (± 0.57%)}	_{2.65s (± 0.62%)}	_~	_2.63s	_2.67s	_{p=0.287 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{0.99s (± 0.90%)}	_~	_0.98s	_1.00s	_{p=0.798 n=6}
_{Check Time}	_{17.29s (± 0.52%)}	_{17.26s (± 0.38%)}	_~	_17.14s	_17.34s	_{p=0.521 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.93s (± 0.40%)}	_{20.90s (± 0.33%)}	_~	_20.77s	_20.97s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,269,069k (± 0.00%)}	_{2,269,063k (± 0.00%)}	_~	_2,269,000k	_2,269,115k	_{p=1.000 n=6}
_{Parse Time}	_{11.88s (± 0.90%)}	_{11.88s (± 0.94%)}	_~	_11.75s	_12.03s	_{p=1.000 n=6}
_{Bind Time}	_{2.64s (± 0.46%)}	_{2.64s (± 0.37%)}	_~	_2.63s	_2.65s	_{p=0.498 n=6}
_{Check Time}	_{101.62s (± 1.42%)}	_{101.81s (± 0.72%)}	_~	_101.05s	_102.89s	_{p=0.689 n=6}
_{Emit Time}	_{0.32s (± 1.74%)}	_{0.32s (± 1.74%)}	_~	_0.31s	_0.32s	_{p=1.000 n=6}
_{Total Time}	_{116.45s (± 1.28%)}	_{116.64s (± 0.59%)}	_~	_115.75s	_117.63s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,413,893k (± 0.02%)}	_{2,413,972k (± 0.02%)}	_~	_2,413,226k	_2,414,762k	_{p=0.810 n=6}
_{Parse Time}	_{4.92s (± 1.26%)}	_{4.90s (± 1.02%)}	_~	_4.85s	_4.97s	_{p=0.572 n=6}
_{Bind Time}	_{1.87s (± 0.68%)}	_{1.87s (± 0.79%)}	_~	_1.85s	_1.89s	_{p=0.869 n=6}
_{Check Time}	_{33.30s (± 0.42%)}	_{33.40s (± 0.54%)}	_~	_33.04s	_33.52s	_{p=0.199 n=6}
_{Emit Time}	_{2.69s (± 1.62%)}	_{2.67s (± 1.31%)}	_~	_2.64s	_2.73s	_{p=0.809 n=6}
_{Total Time}	_{42.81s (± 0.37%)}	_{42.87s (± 0.27%)}	_~	_42.64s	_42.96s	_{p=0.229 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,738k (± 0.01%)}	_{418,742k (± 0.01%)}	_~	_418,679k	_418,804k	_{p=0.810 n=6}
_{Parse Time}	_{2.79s (± 2.91%)}	_{2.78s (± 2.99%)}	_~	_2.66s	_2.87s	_{p=0.747 n=6}
_{Bind Time}	_{1.12s (± 6.23%)}	_{1.13s (± 6.41%)}	_~	_1.08s	_1.22s	_{p=0.344 n=6}
_{Check Time}	_{15.09s (± 0.23%)}	_{15.10s (± 0.27%)}	_~	_15.04s	_15.16s	_{p=0.747 n=6}
_{Emit Time}	_{1.15s (± 0.45%)}	_{1.14s (± 1.29%)}	_~	_1.12s	_1.16s	_{p=0.667 n=6}
_{Total Time}	_{20.14s (± 0.17%)}	_{20.15s (± 0.30%)}	_~	_20.08s	_20.22s	_{p=0.744 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,826,978k (± 0.00%)}	_{2,826,965k (± 0.00%)}	_~	_2,826,926k	_2,827,029k	_{p=0.521 n=6}
_{Parse Time}	_{10.74s (± 0.57%)}	_{10.73s (± 0.44%)}	_~	_10.68s	_10.78s	_{p=0.936 n=6}
_{Bind Time}	_{3.43s (± 0.75%)}	_{3.41s (± 0.22%)}	_~	_3.40s	_3.42s	_{p=0.100 n=6}
_{Check Time}	_{60.10s (± 0.63%)}	_{60.28s (± 0.59%)}	_~	_59.83s	_60.69s	_{p=0.298 n=6}
_{Emit Time}	_{16.17s (± 0.87%)}	_{16.23s (± 0.53%)}	_~	_16.10s	_16.37s	_{p=0.470 n=6}
_{Total Time}	_{90.43s (± 0.41%)}	_{90.66s (± 0.46%)}	_~	_90.03s	_91.06s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{393,433k (± 0.02%)}	_{393,441k (± 0.01%)}	_~	_393,405k	_393,483k	_{p=0.471 n=6}
_{Parse Time}	_{3.11s (± 0.89%)}	_{3.10s (± 0.91%)}	_~	_3.07s	_3.14s	_{p=0.373 n=6}
_{Bind Time}	_{1.38s (± 1.26%)}	_{1.38s (± 1.34%)}	_~	_1.36s	_1.40s	_{p=0.866 n=6}
_{Check Time}	_{14.02s (± 0.22%)}	_{14.07s (± 0.35%)}	_~	_14.01s	_14.12s	_{p=0.108 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.51s (± 0.25%)}	_{18.55s (± 0.27%)}	_~	_18.48s	_18.62s	_{p=0.147 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,374k (± 0.01%)}	_{513,405k (± 0.01%)}	_~	_513,287k	_513,495k	_{p=0.297 n=6}
_{Parse Time}	_{3.28s (± 0.25%)}	_{3.28s (± 0.12%)}	_~	_3.28s	_3.29s	_{p=0.206 n=6}
_{Bind Time}	_{1.54s (± 0.26%)}	_{1.54s (± 0.41%)}	_~	_1.53s	_1.55s	_{p=0.673 n=6}
_{Check Time}	_{2.85s (± 0.65%)}	_{2.85s (± 0.52%)}	_~	_2.84s	_2.88s	_{p=0.871 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.08s (± 5.21%)}	_~	_0.07s	_0.08s	_{p=0.114 n=6}
_{Total Time}	_{7.76s (± 0.30%)}	_{7.76s (± 0.21%)}	_~	_7.75s	_7.79s	_{p=0.506 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-02-08T19:38:14Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-02-08T20:46:59Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57341/merge:

Everything looks good!

gabritto · 2024-04-05T03:59:19Z

src/compiler/checker.ts

                    return Ternary.False;
                }
+                else if (isThisTypePredicate(targetTypePredicate)) {
+                    result &= compareTypes(sourceReturnType, targetReturnType, reportErrors);


That doesn't look right. We don't consider a function with a boolean return type assignable to a function with an identifier type predicate, as the code above implies. So I think instead of adding this change, what we want to do is change the condition above to also account for this type predicates: they should behave the same as identifier type predicates.

Updated. However, it could potentially break some seemingly innocent code.

interface LineCollection { isLeaft(): this is LineLeaf; } class LineNode implements LineCollection { isLeaf() { return false; } }

gabritto · 2024-04-05T04:01:27Z

tests/baselines/reference/typePredicateInherit.errors.txt

+!!! error TS2416:   Type '() => void' is not assignable to type '() => boolean'.
+!!! error TS2416:     Type 'void' is not assignable to type 'boolean'.
+
+      method3() {   // should ok


This should be an error too.

gabritto · 2024-04-08T18:17:57Z

src/server/scriptVersionCache.ts

    }

-    isLeaf() {
+    isLeaf(): this is LineLeaf {


gabritto · 2024-04-08T18:25:24Z

@typescript-bot test it

typescript-bot · 2024-04-08T18:25:27Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-08T18:52:23Z

Hey @gabritto, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: vinyl-file
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/vinyl-file/index.d.ts
  17:18  error  TypeScript@local compile error: 
Interface 'VinylFile' incorrectly extends interface 'File'.
  Types of property 'isBuffer' are incompatible.
    Type '() => boolean' is not assignable to type '() => this is BufferFile'.
      Signature '(): boolean' must be a type predicate  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.19_typescript@5.5.0-dev.20240408/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.19_typescript@5.5.0-dev.20240408/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: vinyl
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/vinyl/index.d.ts
  335:15  error  TypeScript@local compile error: 
Interface 'BufferFile' incorrectly extends interface 'File'.
  Types of property 'isBuffer' are incompatible.
    Type '() => true' is not assignable to type '() => this is BufferFile'.
      Signature '(): true' must be a type predicate               @definitelytyped/expect
  344:15  error  TypeScript@local compile error: 
Interface 'StreamFile' incorrectly extends interface 'File'.
  Types of property 'isStream' are incompatible.
    Type '() => true' is not assignable to type '() => this is StreamFile'.
      Signature '(): true' must be a type predicate               @definitelytyped/expect
  353:15  error  TypeScript@local compile error: 
Interface 'NullFile' incorrectly extends interface 'File'.
  Types of property 'isNull' are incompatible.
    Type '() => true' is not assignable to type '() => this is NullFile'.
      Signature '(): true' must be a type predicate                     @definitelytyped/expect
  362:15  error  TypeScript@local compile error: 
Interface 'DirectoryFile' incorrectly extends interface 'NullFile'.
  Types of property 'isDirectory' are incompatible.
    Type '() => true' is not assignable to type '() => this is DirectoryFile'.
      Signature '(): true' must be a type predicate  @definitelytyped/expect
  367:15  error  TypeScript@local compile error: 
Interface 'SymbolicFile' incorrectly extends interface 'NullFile'.
  Types of property 'isSymbolic' are incompatible.
    Type '() => true' is not assignable to type '() => this is SymbolicFile'.
      Signature '(): true' must be a type predicate     @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/vinyl/vinyl-tests.ts
  659:26  error  TypeScript@local compile error: 
Conversion of type 'NullFile' to type 'TestFile' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Types of property 'isNull' are incompatible.
    Type '() => true' is not comparable to type '() => this is NullFile'.
      Signature '(): true' must be a type predicate  @definitelytyped/expect
  705:26  error  TypeScript@local compile error: 
Conversion of type 'NullFile' to type 'TestFile' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first                                                                                                                                                                                @definitelytyped/expect

✖ 7 problems (7 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.19_typescript@5.5.0-dev.20240408/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.19_typescript@5.5.0-dev.20240408/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: winjs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/winjs/index.d.ts
  10026:9  error  TypeScript@local compile error: 
Property 'every' in type 'QueryCollection<T>' is not assignable to the same property in base type 'T[]'.
  Type '(callbackfn: (value: T, index: number, array: T[]) => boolean, thisArg?: any) => boolean' is not assignable to type '{ <S extends T>(predicate: (value: T, index: number, array: T[]) => value is S, thisArg?: any): this is S[]; (predicate: (value: T, index: number, array: T[]) => unknown, thisArg?: any): boolean; }'.
    Signature '(callbackfn: (value: T, index: number, array: T[]) => boolean, thisArg?: any): boolean' must be a type predicate  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.19_typescript@5.5.0-dev.20240408/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.19_typescript@5.5.0-dev.20240408/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2024-04-08T18:52:31Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,712k (± 0.01%)}	_{295,723k (± 0.01%)}	_~	_295,680k	_295,744k	_{p=0.229 n=6}
_{Parse Time}	_{3.18s (± 0.47%)}	_{3.19s (± 0.58%)}	_~	_3.17s	_3.21s	_{p=0.458 n=6}
_{Bind Time}	_{0.98s (± 2.04%)}	_{0.98s (± 1.53%)}	_~	_0.97s	_1.00s	_{p=0.655 n=6}
_{Check Time}	_{9.67s (± 0.19%)}	_{9.64s (± 0.35%)}	_~	_9.61s	_9.70s	_{p=0.126 n=6}
_{Emit Time}	_{8.42s (± 0.59%)}	_{8.38s (± 0.50%)}	_~	_8.32s	_8.44s	_{p=0.172 n=6}
_{Total Time}	_{22.25s (± 0.24%)}	_{22.20s (± 0.29%)}	_~	_22.11s	_22.29s	_{p=0.172 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,267k (± 0.73%)}	_{193,475k (± 1.01%)}	_~	_191,646k	_195,317k	_{p=0.261 n=6}
_{Parse Time}	_{2.03s (± 1.57%)}	_{2.02s (± 1.02%)}	_~	_1.99s	_2.05s	_{p=0.808 n=6}
_{Bind Time}	_{1.07s (± 1.15%)}	_{1.06s (± 1.03%)}	_~	_1.05s	_1.08s	_{p=0.507 n=6}
_{Check Time}	_{13.83s (± 0.41%)}	_{13.85s (± 0.70%)}	_~	_13.74s	_13.98s	_{p=0.810 n=6}
_{Emit Time}	_{3.85s (± 0.79%)}	_{3.85s (± 0.38%)}	_~	_3.83s	_3.87s	_{p=0.567 n=6}
_{Total Time}	_{20.78s (± 0.41%)}	_{20.79s (± 0.48%)}	_~	_20.69s	_20.93s	_{p=0.873 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,706k (± 0.00%)}	_{347,701k (± 0.00%)}	_~	_347,689k	_347,717k	_{p=0.575 n=6}
_{Parse Time}	_{3.67s (± 1.49%)}	_{3.68s (± 1.20%)}	_~	_3.63s	_3.74s	_{p=0.809 n=6}
_{Bind Time}	_{1.33s (± 2.75%)}	_{1.32s (± 1.51%)}	_~	_1.29s	_1.35s	_{p=0.935 n=6}
_{Check Time}	_{10.11s (± 0.42%)}	_{10.09s (± 0.44%)}	_~	_10.04s	_10.17s	_{p=0.572 n=6}
_{Emit Time}	_{6.01s (± 0.52%)}	_{6.02s (± 0.29%)}	_~	_5.99s	_6.04s	_{p=0.366 n=6}
_{Total Time}	_{21.12s (± 0.13%)}	_{21.11s (± 0.37%)}	_~	_21.06s	_21.26s	_{p=0.223 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,587k (± 0.01%)}	_{302,565k (± 0.01%)}	_~	_302,539k	_302,613k	_{p=0.173 n=6}
_{Parse Time}	_{2.39s (± 0.90%)}	_{2.41s (± 1.25%)}	_~	_2.38s	_2.45s	_{p=0.374 n=6}
_{Bind Time}	_{1.16s (± 0.54%)}	_{1.17s (± 0.72%)}	_~	_1.16s	_1.18s	_{p=0.340 n=6}
_{Check Time}	_{7.45s (± 0.30%)}	_{7.43s (± 0.27%)}	_~	_7.40s	_7.46s	_{p=0.257 n=6}
_{Emit Time}	_{4.28s (± 0.41%)}	_{4.26s (± 0.75%)}	_~	_4.21s	_4.30s	_{p=0.623 n=6}
_{Total Time}	_{15.28s (± 0.22%)}	_{15.27s (± 0.35%)}	_~	_15.21s	_15.36s	_{p=0.747 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,526k (± 0.01%)}	_{510,512k (± 0.00%)}	_~	_510,496k	_510,519k	_{p=0.229 n=6}
_{Parse Time}	_{2.66s (± 0.31%)}	_{2.68s (± 0.65%)}	_~	_2.66s	_2.71s	_{p=0.121 n=6}
_{Bind Time}	_{0.98s (± 0.83%)}	_{0.99s (± 0.83%)}	_~	_0.98s	_1.00s	_{p=0.666 n=6}
_{Check Time}	_{17.15s (± 0.25%)}	_{17.23s (± 0.38%)}	_{+0.08s (+ 0.44%)}	_17.16s	_17.34s	_{p=0.043 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.80s (± 0.18%)}	_{20.89s (± 0.30%)}	_{+0.09s (+ 0.44%)}	_20.83s	_21.00s	_{p=0.016 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,743,838k (± 0.00%)}	_{1,743,793k (± 0.00%)}	_{-44k (- 0.00%)}	_1,743,754k	_1,743,827k	_{p=0.031 n=6}
_{Parse Time}	_{7.83s (± 0.48%)}	_{7.79s (± 0.51%)}	_~	_7.74s	_7.85s	_{p=0.109 n=6}
_{Bind Time}	_{2.73s (± 0.89%)}	_{2.75s (± 1.34%)}	_~	_2.72s	_2.81s	_{p=0.418 n=6}
_{Check Time}	_{66.48s (± 0.51%)}	_{66.25s (± 0.29%)}	_~	_65.88s	_66.41s	_{p=0.173 n=6}
_{Emit Time}	_{0.16s (± 3.29%)}	_{0.15s (± 3.53%)}	_~	_0.15s	_0.16s	_{p=0.640 n=6}
_{Total Time}	_{77.20s (± 0.42%)}	_{76.93s (± 0.22%)}	_~	_76.61s	_77.07s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,299,391k (± 0.05%)}	_{2,299,518k (± 0.05%)}	_~	_2,297,561k	_2,301,146k	_{p=1.000 n=6}
_{Parse Time}	_{7.38s (± 0.96%)}	_{7.42s (± 0.40%)}	_~	_7.37s	_7.45s	_{p=0.471 n=6}
_{Bind Time}	_{2.70s (± 0.41%)}	_{2.70s (± 0.77%)}	_~	_2.68s	_2.73s	_{p=0.622 n=6}
_{Check Time}	_{48.78s (± 0.81%)}	_{48.59s (± 0.39%)}	_~	_48.23s	_48.80s	_{p=0.298 n=6}
_{Emit Time}	_{3.85s (± 4.64%)}	_{3.84s (± 3.60%)}	_~	_3.71s	_4.04s	_{p=0.873 n=6}
_{Total Time}	_{62.71s (± 0.74%)}	_{62.57s (± 0.39%)}	_~	_62.21s	_62.81s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,374,097k (± 0.03%)}	_{2,373,779k (± 0.04%)}	_~	_2,372,687k	_2,374,948k	_{p=0.689 n=6}
_{Parse Time}	_{7.66s (± 0.61%)}	_{7.66s (± 1.27%)}	_~	_7.55s	_7.79s	_{p=0.748 n=6}
_{Bind Time}	_{2.47s (± 1.01%)}	_{2.46s (± 1.52%)}	_~	_2.40s	_2.50s	_{p=0.294 n=6}
_{Check Time}	_{49.28s (± 0.52%)}	_{49.29s (± 0.36%)}	_~	_49.06s	_49.55s	_{p=0.810 n=6}
_{Emit Time}	_{3.90s (± 2.08%)}	_{3.90s (± 1.27%)}	_~	_3.87s	_4.00s	_{p=0.810 n=6}
_{Total Time}	_{63.33s (± 0.43%)}	_{63.33s (± 0.15%)}	_~	_63.22s	_63.50s	_{p=0.423 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,079k (± 0.01%)}	_{418,085k (± 0.01%)}	_~	_418,028k	_418,121k	_{p=1.000 n=6}
_{Parse Time}	_{4.14s (± 0.33%)}	_{4.15s (± 0.39%)}	_~	_4.13s	_4.17s	_{p=0.324 n=6}
_{Bind Time}	_{1.60s (± 0.92%)}	_{1.60s (± 0.68%)}	_~	_1.59s	_1.62s	_{p=1.000 n=6}
_{Check Time}	_{22.01s (± 0.26%)}	_{22.00s (± 0.27%)}	_~	_21.93s	_22.07s	_{p=1.000 n=6}
_{Emit Time}	_{1.70s (± 1.26%)}	_{1.70s (± 2.03%)}	_~	_1.67s	_1.76s	_{p=0.685 n=6}
_{Total Time}	_{29.45s (± 0.21%)}	_{29.45s (± 0.22%)}	_~	_29.35s	_29.53s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,904,054k (± 0.00%)}	_{2,904,030k (± 0.00%)}	_~	_2,903,975k	_2,904,090k	_{p=0.689 n=6}
_{Parse Time}	_{10.88s (± 0.24%)}	_{10.84s (± 0.38%)}	_~	_10.80s	_10.89s	_{p=0.169 n=6}
_{Bind Time}	_{3.40s (± 0.25%)}	_{3.39s (± 0.39%)}	_~	_3.37s	_3.41s	_{p=0.788 n=6}
_{Check Time}	_{61.42s (± 0.48%)}	_{61.64s (± 0.21%)}	_~	_61.49s	_61.87s	_{p=0.378 n=6}
_{Emit Time}	_{16.56s (± 0.72%)}	_{16.40s (± 0.77%)}	_{-0.16s (- 0.98%)}	_16.27s	_16.62s	_{p=0.045 n=6}
_{Total Time}	_{92.26s (± 0.35%)}	_{92.28s (± 0.22%)}	_~	_92.04s	_92.58s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,676k (± 0.01%)}	_{408,643k (± 0.01%)}	_~	_408,584k	_408,709k	_{p=0.378 n=6}
_{Parse Time}	_{3.87s (± 0.60%)}	_{3.90s (± 0.62%)}	_~	_3.87s	_3.94s	_{p=0.104 n=6}
_{Bind Time}	_{1.66s (± 1.08%)}	_{1.66s (± 0.73%)}	_~	_1.65s	_1.68s	_{p=0.806 n=6}
_{Check Time}	_{16.65s (± 0.15%)}	_{16.68s (± 0.30%)}	_~	_16.63s	_16.76s	_{p=0.294 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.18s (± 0.15%)}	_{22.25s (± 0.29%)}	_~	_22.17s	_22.34s	_{p=0.078 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{514,468k (± 0.02%)}	_{670,860k (± 0.02%)}	_{🔻+156,393k (+30.40%)}	_670,710k	_671,016k	_{p=0.005 n=6}
_{Parse Time}	_{4.92s (± 0.33%)}	_{4.98s (± 0.95%)}	_{+0.06s (+ 1.22%)}	_4.90s	_5.03s	_{p=0.044 n=6}
_{Bind Time}	_{2.31s (± 0.92%)}	_{2.31s (± 0.52%)}	_~	_2.30s	_2.33s	_{p=1.000 n=6}
_{Check Time}	_{4.23s (± 0.50%)}	_{4.24s (± 0.92%)}	_~	_4.19s	_4.29s	_{p=1.000 n=6}
_{Emit Time}	_{0.11s (± 4.55%)}	_{0.03s (± 0.00%)}	_{🟩-0.08s (-73.53%)}	_0.03s	_0.03s	_{p=0.002 n=6}
_{Total Time}	_{11.57s (± 0.39%)}	_{11.57s (± 0.57%)}	_~	_11.52s	_11.67s	_{p=0.375 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-08T19:02:48Z

@gabritto Here are the results of running the user tests comparing main and refs/pull/57341/merge:

Everything looks good!

gabritto · 2024-04-08T19:10:43Z

I'm guessing this PR breaks xstate:

typescript-bot · 2024-04-08T20:18:16Z

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/57341/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

4 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2322: Type '<T, TChange>(o: IObservable<T, TChange>) => boolean' is not assignable to type '<T, TChange>(observable: IObservable<T, TChange>) => this is { change: TChange; }'.
- src/vs/base/common/observableInternal/autorun.ts#L256
- src/vs/base/common/observableInternal/derived.ts#L341
error TS2420: Class 'NotebookEditorTestModel' incorrectly implements interface 'INotebookEditorModel'.
- src/vs/workbench/contrib/notebook/test/browser/testNotebookEditor.ts#L85
error TS2322: Type 'this' is not assignable to type 'IResolvedNotebookEditorModel'.
- src/vs/workbench/contrib/notebook/test/browser/testNotebookEditor.ts#L157

src/tsconfig.monaco.json

error TS2322: Type '<T, TChange>(o: IObservable<T, TChange>) => boolean' is not assignable to type '<T, TChange>(observable: IObservable<T, TChange>) => this is { change: TChange; }'.
- src/vs/base/common/observableInternal/autorun.ts#L256
- src/vs/base/common/observableInternal/derived.ts#L341

src/tsconfig.json

error TS2322: Type '<T, TChange>(o: IObservable<T, TChange>) => boolean' is not assignable to type '<T, TChange>(observable: IObservable<T, TChange>) => this is { change: TChange; }'.
- src/vs/base/common/observableInternal/autorun.ts#L256
- src/vs/base/common/observableInternal/derived.ts#L341
error TS2420: Class 'NotebookEditorTestModel' incorrectly implements interface 'INotebookEditorModel'.
- src/vs/workbench/contrib/notebook/test/browser/testNotebookEditor.ts#L85
error TS2322: Type 'this' is not assignable to type 'IResolvedNotebookEditorModel'.
- src/vs/workbench/contrib/notebook/test/browser/testNotebookEditor.ts#L157

check return type of this type predicates

62072f4

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 8, 2024

format code

89a7208

sandersn requested review from gabritto and weswigham February 16, 2024 14:33

sandersn assigned weswigham Feb 16, 2024

gabritto requested changes Apr 5, 2024

View reviewed changes

Zzzen added 4 commits April 6, 2024 16:35

stricter check

b811562

Merge remote-tracking branch 'origin/main' into check-this-predicate

4c9edfe

update baseline

c068296

update baseline

f889bfc

gabritto approved these changes Apr 8, 2024

View reviewed changes

src/server/scriptVersionCache.ts

}

isLeaf() {

isLeaf(): this is LineLeaf {

Copy link

Member

gabritto Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😦

gabritto merged commit f608fc0 into microsoft:main Apr 8, 2024

gabritto added the Breaking Change Would introduce errors in existing code label Apr 9, 2024

This was referenced Apr 10, 2024

[vinyl][vinyl-file] Fix 5.5 nightly errors DefinitelyTyped/DefinitelyTyped#69319

Merged

[winjs] Fix 5.5 nightly errors DefinitelyTyped/DefinitelyTyped#69320

Merged

Interface cannot override predicate return type with boolean #58202

Closed

DanielRosenwasser mentioned this pull request May 2, 2024

Design Meeting Notes, 4/16/2024 #58414

Closed

Andarist mentioned this pull request Jul 12, 2024

Incorrect report of Signature '(): false' must be a type predicate since TS 5.5 #59252

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

Zzzen commented Feb 8, 2024

Uh oh!

jakebailey commented Feb 8, 2024

Uh oh!

typescript-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 8, 2024

Uh oh!

typescript-bot commented Feb 8, 2024

tsc

Uh oh!

typescript-bot commented Feb 8, 2024

Uh oh!

typescript-bot commented Feb 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zzzen Apr 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gabritto commented Apr 8, 2024

Uh oh!

typescript-bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 8, 2024

Uh oh!

typescript-bot commented Apr 8, 2024

tsc

Uh oh!

typescript-bot commented Apr 8, 2024

Uh oh!

gabritto commented Apr 8, 2024

Uh oh!

typescript-bot commented Apr 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Feb 8, 2024 •

edited

Loading

typescript-bot commented Feb 8, 2024 •

edited

Loading

typescript-bot commented Feb 8, 2024 •

edited

Loading

typescript-bot commented Feb 8, 2024 •

edited

Loading

typescript-bot commented Feb 8, 2024 •

edited

Loading

typescript-bot commented Feb 8, 2024 •

edited

Loading

Zzzen Apr 6, 2024 •

edited

Loading

typescript-bot commented Apr 8, 2024 •

edited

Loading